misc: pre-release warning cleanup #291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Arduino Nano Matter is an official Arduino board, so use the zephyr_main artifact for it. Signed-off-by: Luca Burelli <[email protected]>
Fixes ArduinoBLE tests not passing due to missing ADC pin definitions. Signed-off-by: Luca Burelli <[email protected]>
Use the ARG_UNUSED macro provided by Zephyr to mark function parameters as intentionally unused to prevent compiler warnings. Signed-off-by: Luca Burelli <[email protected]>
Add missing default return values to functions returning non-void. Also remove spuperfluous 'return;' statements at the end of functions. Signed-off-by: Luca Burelli <[email protected]>
Constructors should initialize members in the order they are declared in the class definition. Signed-off-by: Luca Burelli <[email protected]>
- expect a 'const char*' for netmask (caused issues with string literals) - use a 'uint64_t' for additional_event_mask, as the extra bits are used by Zephyr. Signed-off-by: Luca Burelli <[email protected]>
- Arduino_LED_Matrix: fix packed attribute placement, add missing dependency - Camera: fix pixel format check (formats are uint32_t, not pointers) - Ethernet: fix float division literals - SocketWrapper: hide deprecated warnings, fix signed/unsigned compare - Wire: hide pedantic 'invalid offsetof' warning
- Arduino_RPClite to 0.2.1 - Arduino_RouterBridge to 0.3.0
pennam
approved these changes
Dec 15, 2025
|
Tested ArduinoBLE LED.ino ✔️ |
|
Other tests:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
zephyr_mainCI run with full test coverage for this PR is here.