Move script entry point #4151
Merged
Move script entry point #4151
+142
−154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h8d13
reviewed
Jan 20, 2026
| error('Run archinstall --debug and check /var/log/archinstall/install.log for details.') | ||
|
|
||
| debug(f'Failed to sync Arch Linux package database: {e}') | ||
| sys.exit(1) |
Contributor
There was a problem hiding this comment.
shoulnd't these also be returns if they are received by rc ?
Contributor
Author
There was a problem hiding this comment.
This is a code move, not a refactor. It is best to keep a pull request focused on one thing and as small as possible that way it is easier to review amongst other benefits.
There is plenty that can be refactored here but that is irrelevant to this pull request.
svartkanin
approved these changes
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4148