Update various string resources for consistency and clarity#1054
Open
Elissa-AppDevforAll wants to merge 1 commit intostagefrom
Open
Update various string resources for consistency and clarity#1054Elissa-AppDevforAll wants to merge 1 commit intostagefrom
Elissa-AppDevforAll wants to merge 1 commit intostagefrom
Conversation
Collaborator
Elissa-AppDevforAll
commented
Mar 9, 2026
Elissa-AppDevforAll
commented
- Beefed up the permissions descriptions so we can remove the intermediary page.
- Rewrote the hint that shows when the user can't enable Display over other app--the issue isn't limited just to Pixel phones.
- Changed debugger-pairing success message from "yada Shizuku yada" to provide instructions to return to Code on the Go.
- Removed some incorrect capital letters.
- Fixed typographical problems.
Beefed up the permissions descriptions so we can remove the intermediary page. Rewrote the hint that shows when the user can't enable Display over other app--the issue isn't limited just to Pixel phones Removed some incorrect capital letters. Fixed typographical problems.
Contributor
📝 WalkthroughRelease Notes - String Resource Updates for Consistency and ClarityPermission Descriptions Expanded
UI Text Capitalization Standardized
Debugger Service and Notification Updates
Build Status Messages
Punctuation Refinement
Risks and Best Practice Considerations
WalkthroughThis PR updates string resources in the plugin template UI, permissions descriptions, and user-facing messages. Changes include capitalizing labels to lowercase style ("Plugin Name" → "Plugin name"), refining permission descriptions for clarity, renaming overlay permission to "Floating debugger," and adjusting notification and build status messaging for better UX consistency. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
resources/src/main/res/values/strings.xml (1)
692-692: The hint is clearer but consider consistency with line 701.The rewritten hint removes device-specific assumptions effectively. However, line 701 (
permissions_info_overlay_accessibility) uses a different navigation phrase: "go to Settings → Apps → Code on the Go" vs. this line's "display App info for Code on the Go."Both reach the same destination, but if these strings might be shown in the same user journey, consider aligning the wording. If they appear in different contexts (line 692 via
flashError()per the context snippet, line 701 in onboarding), the variation may be acceptable.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@resources/src/main/res/values/strings.xml` at line 692, The two related string resources are inconsistent in navigation phrasing: update the string named permission_overlay_restricted_settings_hint to match the phrasing used in permissions_info_overlay_accessibility (or vice versa) so both use the same navigation style (e.g., "Go to Settings → Apps → Code on the Go, tap the three-dot menu, and enable restricted settings.") to ensure consistent user guidance across onboarding and flashError() flows.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@resources/src/main/res/values/strings.xml`:
- Line 692: The two related string resources are inconsistent in navigation
phrasing: update the string named permission_overlay_restricted_settings_hint to
match the phrasing used in permissions_info_overlay_accessibility (or vice
versa) so both use the same navigation style (e.g., "Go to Settings → Apps →
Code on the Go, tap the three-dot menu, and enable restricted settings.") to
ensure consistent user guidance across onboarding and flashError() flows.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 1a1b8957-62cb-40e2-8179-527985d8eb8d
📒 Files selected for processing (1)
resources/src/main/res/values/strings.xml
itsaky-adfa
approved these changes
Mar 11, 2026
jatezzz
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.