Skip to content

ADFA-3070 Turns off nested scrolling for the chat list. #1013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hal-eisen-adfa wants to merge 1 commit into
base: stage
Choose a base branch
from
Open

ADFA-3070 Turns off nested scrolling for the chat list. #1013

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions app/src/main/java/com/itsaky/androidide/agent/fragments/ChatFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,11 @@ import android.util.Log
import android.view.KeyEvent
import android.view.MotionEvent
import android.view.View
import android.view.ViewGroup
import android.view.inputmethod.InputMethodManager
import androidx.activity.result.ActivityResultLauncher
import androidx.activity.result.contract.ActivityResultContracts
import androidx.core.view.ViewCompat
import androidx.core.view.WindowInsetsCompat
import androidx.core.view.isVisible
import androidx.core.view.updateLayoutParams
Expand Down Expand Up @@ -232,6 +234,31 @@ class ChatFragment : EmptyStateFragment<FragmentChatBinding>(FragmentChatBinding
LinearLayoutManager(requireContext()).apply {
stackFromEnd = true
}
// Prevent nested scroll from propagating to CoordinatorLayout so the app bar (project
// name, actions toolbar) does not scroll when the user scrolls the agent chat list.
ViewCompat.setNestedScrollingEnabled(binding.chatRecyclerView, false)
// Let the list scroll instead of the bottom sheet when the user drags over the chat.
binding.chatRecyclerView.addOnItemTouchListener(
object : RecyclerView.OnItemTouchListener {
override fun onInterceptTouchEvent(
rv: RecyclerView,
e: MotionEvent,
): Boolean {
if (e.actionMasked == MotionEvent.ACTION_DOWN) {
var p = rv.parent
while (p is ViewGroup) {
p.requestDisallowInterceptTouchEvent(true)
p = p.parent
}
}
return false
}

override fun onTouchEvent(rv: RecyclerView, e: MotionEvent) {}

override fun onRequestDisallowInterceptTouchEvent(disallowIntercept: Boolean) {}
},
)
}

private fun setupListeners() {
Expand Down