[SYSTEMDS-3933] Generalize OOC matrix-vector binary to support streamed vector input #2386
+29
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumos07
force-pushed
the
test/SYSTEMDS-3933-ooc-matrix-vector
branch
from
50d43b6 to
fcf5c6f
Compare
Author
|
It appears the issue is resolved by the recent refactor using submitOOCTasks and partitionedVector. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes the assumption that the vector operand in
MatrixVectorBinaryOOCInstruction fits in memory.
Both operands are now handled via OOC streams. The vector stream is
consumed once and cached block-wise, allowing correct execution when
the vector itself is large or stored out-of-core.
Operator semantics and aggregation behavior remain unchanged.
Tested with MatrixVectorBinaryMultiplicationTest under OOC execution.