SOLR-18095: Add ability to map writer types and handlers to a No Operation version.#4091
Open
epugh wants to merge 12 commits intoapache:mainfrom
Open
SOLR-18095: Add ability to map writer types and handlers to a No Operation version.#4091epugh wants to merge 12 commits intoapache:mainfrom
epugh wants to merge 12 commits intoapache:mainfrom
Conversation
github-actions
bot
added
documentation
Contributor
Author
|
This PR accomplishes what I wanted, which is disabling ImplicitPlugin defined items. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-18095
Description
This brings back a (simplified!) NoOpResponseWriter and adds a NoOpRequestWriter as well.
This is an alternative to https://issues.apache.org/jira/browse/SOLR-18079
Solution
Just re-introduce NoOp versions and allow remapping. Does add explicit documentation in the ref guide.
Tests
added a test, though almost thing it's not worth it!