-
Notifications
You must be signed in to change notification settings - Fork 1.4k
style: Reformat comments and long lines in RetentionManagerTest for…
#17556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
… improved readability.
|
This is not the code style we use. Please configure your IDE with Pinot Style |
|
“Got it — I’ll configure my IDE to follow the Pinot Style. Thanks for the heads-up.” |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR reformats comments and long lines in RetentionManagerTest and related files to improve code readability by adhering to standard line length conventions.
Changes:
- Wrapped long comments across multiple lines to stay within line length limits
- Reformatted multi-line method calls and variable assignments for better readability
- Removed unnecessary blank lines for cleaner code structure
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| RetentionManagerTest.java | Reformatted comments and method calls throughout test file for improved readability |
| RetentionManager.java | Wrapped long comments and method signatures, added new overloaded method call for multi-topic handling |
| PinotHelixResourceManager.java | Added new overloaded method with documentation and null check for handling multi-topic stream configs |
| if (llcName == null) { | ||
| continue; | ||
| } |
Copilot
AI
Jan 23, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A null check for llcName is added in the original getLastLLCCompletedSegments() method but this method was not previously checking for null. This changes the behavior of the existing method. The null check should only be in the new overloaded method to avoid altering the behavior of the existing API.
| if (llcName == null) { | |
| continue; | |
| } |
| manageRetentionForHybridTable(tableConfig, offlineTableConfig); | ||
| } else { | ||
| manageRetentionForRealtimeTable(tableNameWithType, retentionStrategy, untrackedSegmentsDeletionBatchSize, | ||
| manageRetentionForRealtimeTable(tableConfig, retentionStrategy, untrackedSegmentsDeletionBatchSize, |
Copilot
AI
Jan 23, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The method signature of manageRetentionForRealtimeTable changed from accepting String realtimeTableName to TableConfig tableConfig. While the new parameter is more flexible, this is a breaking change to the method signature. Consider deprecating the old signature if this is meant to be part of the public API, or document this as a breaking change.
… improved readability.
Instructions:
featurebugfixperformanceuibackward-incompatrelease-notes(**)(*) Other labels to consider:
testingdependenciesdockerkubernetesobservabilitysecuritycode-styleextension-pointrefactorcleanup(**) Use
release-noteslabel for scenarios like: