Skip to content

Conversation

@iammuntazirali
Copy link

… improved readability.

Instructions:

  1. The PR has to be tagged with at least one of the following labels (*):
    1. feature
    2. bugfix
    3. performance
    4. ui
    5. backward-incompat
    6. release-notes (**)
  2. Remove these instructions before publishing the PR.

(*) Other labels to consider:

  • testing
  • dependencies
  • docker
  • kubernetes
  • observability
  • security
  • code-style
  • extension-point
  • refactor
  • cleanup

(**) Use release-notes label for scenarios like:

  • New configuration options
  • Deprecation of configurations
  • Signature changes to public methods/interfaces
  • New plugins added or old plugins removed

@iammuntazirali iammuntazirali marked this pull request as draft January 22, 2026 11:38
@iammuntazirali iammuntazirali marked this pull request as ready for review January 22, 2026 11:38
@iammuntazirali iammuntazirali marked this pull request as draft January 22, 2026 11:38
@iammuntazirali iammuntazirali marked this pull request as ready for review January 22, 2026 11:38
@Jackie-Jiang
Copy link
Contributor

This is not the code style we use. Please configure your IDE with Pinot Style

@iammuntazirali
Copy link
Author

“Got it — I’ll configure my IDE to follow the Pinot Style. Thanks for the heads-up.”

@xiangfu0 xiangfu0 requested a review from Copilot January 23, 2026 18:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reformats comments and long lines in RetentionManagerTest and related files to improve code readability by adhering to standard line length conventions.

Changes:

  • Wrapped long comments across multiple lines to stay within line length limits
  • Reformatted multi-line method calls and variable assignments for better readability
  • Removed unnecessary blank lines for cleaner code structure

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
RetentionManagerTest.java Reformatted comments and method calls throughout test file for improved readability
RetentionManager.java Wrapped long comments and method signatures, added new overloaded method call for multi-topic handling
PinotHelixResourceManager.java Added new overloaded method with documentation and null check for handling multi-topic stream configs

Comment on lines 1007 to 1009
if (llcName == null) {
continue;
}
Copy link

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A null check for llcName is added in the original getLastLLCCompletedSegments() method but this method was not previously checking for null. This changes the behavior of the existing method. The null check should only be in the new overloaded method to avoid altering the behavior of the existing API.

Suggested change
if (llcName == null) {
continue;
}

Copilot uses AI. Check for mistakes.
manageRetentionForHybridTable(tableConfig, offlineTableConfig);
} else {
manageRetentionForRealtimeTable(tableNameWithType, retentionStrategy, untrackedSegmentsDeletionBatchSize,
manageRetentionForRealtimeTable(tableConfig, retentionStrategy, untrackedSegmentsDeletionBatchSize,
Copy link

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method signature of manageRetentionForRealtimeTable changed from accepting String realtimeTableName to TableConfig tableConfig. While the new parameter is more flexible, this is a breaking change to the method signature. Consider deprecating the old signature if this is meant to be part of the public API, or document this as a breaking change.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants