Skip to content

HDDS-12785. Add an option to disable lifecycle configuration from OM#9638

Closed
chungen0126 wants to merge 4 commits intoapache:HDDS-8342from
chungen0126:HDDS-12785
Closed

HDDS-12785. Add an option to disable lifecycle configuration from OM#9638
chungen0126 wants to merge 4 commits intoapache:HDDS-8342from
chungen0126:HDDS-12785

Conversation

@chungen0126
Copy link
Contributor

@chungen0126 chungen0126 commented Jan 15, 2026

What changes were proposed in this pull request?

This PR introduces a configuration check to disable the Lifecycle feature in Ozone Manager.

  • When the feature is disabled, all Lifecycle-related RPCs (both Write and Read requests) return an error response with status FEATURE_NOT_ENABLED.
  • Blocked requests include: SetLifecycle, DeleteLifecycle, GetLifecycle, and Set/GetLifecycleServiceStatus.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-12785

How was this patch tested?

Added TestOMDisableLifecycle to verify:

  • OzoneManagerRatisUtils.createClientRequest throws exception for write requests.
  • OzoneManagerRequestHandler.handleReadRequest returns failure status for read requests.

ci: https://github.com/chungen0126/ozone/actions/runs/21053143860

@chungen0126 chungen0126 marked this pull request as ready for review January 16, 2026 04:51
@ivandika3 ivandika3 added the s3-lifecycle HDDS-8342 label Jan 16, 2026
Copy link
Contributor

@Gargi-jais11 Gargi-jais11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chungen0126 for the patch.
Please find inline comment.

Comment on lines +1114 to +1115
throw new OMException("OM Lifecycle feature is not enabled. Please "
+ "set ozone.om.lifecycle.service.enabled to true and restart all OMs.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use OZONE_KEY_LIFECYCLE_SERVICE_ENABLED instead of hardcoding it.

throw new OMException("OM Lifecycle feature is not enabled. Please set " + OZONE_KEY_LIFECYCLE_SERVICE_ENABLED + "to true and restart all OMs."

@github-actions
Copy link

This PR has been marked as stale due to 21 days of inactivity. Please comment or remove the stale label to keep it open. Otherwise, it will be automatically closed in 7 days.

@github-actions github-actions bot added the stale label Feb 13, 2026
@github-actions
Copy link

Thank you for your contribution. This PR is being closed due to inactivity. Please contact a maintainer if you would like to reopen it.

@github-actions github-actions bot closed this Feb 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants