fix(#OWB-1450): Interceptor proxy memory leak #128
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmannibucau
reviewed
May 9, 2025
| public AnnotationTypeKey(final AnnotatedType<T> annotatedType) | ||
| { | ||
| Asserts.assertNotNull(annotatedType, "annotatedType"); | ||
| this.annotatedType = annotatedType; |
Contributor
There was a problem hiding this comment.
i'd cache (=precompute in the constructor) the hashcode as in beancachekey since it is hash structure oriented
rmannibucau
reviewed
May 9, 2025
| public void testEnsureOneProxyPerAT() | ||
| { | ||
| // we take a fresh URLClassLoader to not blur the test classpath with synthetic classes. | ||
| ClassLoader classLoader = new URLClassLoader(new URL[0]); |
rmannibucau
reviewed
May 9, 2025
| return true; | ||
| } | ||
|
|
||
| if (annotatedType.getJavaClass() == at.getJavaClass()) |
Contributor
There was a problem hiding this comment.
think it is not sufficient, misses annotations and other parts of the model no?
Contributor
|
Did went directly to main, no? |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.