net/vlan: make a judgment before calling fuction #17695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area: Networking
xiaoxiang781216
previously approved these changes
Dec 26, 2025
acassis
reviewed
Dec 26, 2025
Contributor
Can you please show the steps you used to set up the clan and test Ethernet communication? And show what the results were before your patch? |
Make a judgment before calling fuction. Signed-off-by: gaohedong <[email protected]>
acassis
approved these changes
Dec 27, 2025
xiaoxiang781216
approved these changes
Dec 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Without making a judgment before calling the API implemented by the driver layer, there is a potential risk of crashing.
Make a legality check before calling an uncertain function.
Impact
It will enhance the robustness of the system, but will not affect its functionality.
Testing
Set up Vlan communication environment on the development board, and after modification, Ethernet communication works normally.