net/ethernet: fix compilation issues for inet_sockif.c #17693
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix compilation issues Signed-off-by: gaohedong <[email protected]>
github-actions
bot
added
Area: Networking
xiaoxiang781216
approved these changes
Dec 26, 2025
acassis
reviewed
Dec 26, 2025
| bool "Socket packet socket support" | ||
| default n | ||
| select NETDEV_IFINDEX | ||
| select NET_READAHEAD |
Contributor
There was a problem hiding this comment.
@HedongGao shouldn't it be possible to use NET_PKT without NET_READAHEAD?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When the CONFIG_NET_SOCKOPTS, CONFIG_NET_TIMESTAMP, and CONFIG_NET_UDP_NO_STACK configuration options are enabled and the CONFIG_NET_UDP configuration option is disabled, a compilation error is generated. Modifications have been made to address the aforementioned issues.
inet/inet_sockif.c:772:40: error: invalid use of undefined type ‘struct udp_conn_s’ 772 | *(FAR int *)value = (conn->timestamp != 0); | ^~ inet/inet_sockif.c: In function ‘inet_set_socketlevel_option’: inet/inet_sockif.c:1081:19: error: invalid use of undefined type ‘struct udp_conn_s’ 1081 | conn->timestamp = (*((FAR int *)value) != 0);Impact
No modifications have been made to the functionality, so it will not affect the system.
Testing
As mentioned above, with the above configuration, modifying the code and recompiling, the problem will no longer recur.