-
Notifications
You must be signed in to change notification settings - Fork 1.4k
net/tcp: tcp header seq check #17691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+126
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The Change ID should be removed from the commit message. Do you have any idea why this PR did not trigger the CI? @simbit18 |
Contributor
The first pr from new contributor need be approved manually to filter the garbage patch. |
42c9a63 to
9040944
Compare
xiaoxiang781216
previously approved these changes
Dec 26, 2025
Contributor
|
@wenquan2015 please fix: |
d25be15 to
46a5a05
Compare
anchao
reviewed
Dec 30, 2025
According rfc793 p69, In SYN-RCVD state, if the incoming segment is not acceptable, an acknowledgment should be sent in reply (unless the RST bit is set): <SEQ=SND.NXT><ACK=RCV.NXT><CTL=ACK> Signed-off-by: wenquan1 <[email protected]>
According rfc793 p69, from state SYN-RECEIVED to state TIME-WAIT, if the incoming segment is not acceptable, an acknowledgment should be sent in reply (unless the RST bit is set): <SEQ=SND.NXT><ACK=RCV.NXT><CTL=ACK> Signed-off-by: wenquan1 <[email protected]>
According rfc793 p71, after step1 check OTW seq, and step2 check RST flag, then check syn flag. Signed-off-by: wenquan1 <[email protected]>
…-send state Ignore a segment carrying an unacceptable ACK and RST in syn-send state Signed-off-by: wenquan1 <[email protected]>
Ignore a RST control message in syn-send state Signed-off-by: wenquan1 <[email protected]>
… state Drop the packet with neither SYN or RST flag set in syn-sent state Signed-off-by: wenquan1 <[email protected]>
Ignore fin packet in syn-sent state Signed-off-by: wenquan1 <[email protected]>
Fix send RST bug when receive syn retransmit in syn-rcvd state Signed-off-by: wenquan1 <[email protected]>
anchao
approved these changes
Dec 30, 2025
xiaoxiang781216
approved these changes
Dec 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Check tcp header sndseq and ackseq according to RFC 793.
Impact
tcp
Testing
enable iperf,check iperf test ok