Skip to content

Quote text within regular expression patterns correctly#792

Merged
kwin merged 1 commit intomasterfrom
bugfix/quote-regex-in-simplerelocator
Mar 8, 2026
Merged

Quote text within regular expression patterns correctly#792
kwin merged 1 commit intomasterfrom
bugfix/quote-regex-in-simplerelocator

Conversation

@kwin
Copy link
Member

@kwin kwin commented Mar 5, 2026

Use compiled RegEx patterns to speed up replacement Clarify which pattern fields allow which wildcard (follow which syntax)

This closes #790

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MSHADE-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MSHADE-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@kwin kwin force-pushed the bugfix/quote-regex-in-simplerelocator branch 3 times, most recently from afd8afd to 36a6b0a Compare March 5, 2026 14:12
@kwin kwin marked this pull request as ready for review March 5, 2026 14:12
@kwin kwin requested review from cstamas and olamy March 5, 2026 14:12
Use compiled RegEx patterns to speed up replacement
Clarify which pattern fields allow which wildcard (follow which syntax)
Prevent using empty patterns.
Clarify javadoc for mojo parameter "relocations"

This closes #790
This closes #793
@kwin kwin force-pushed the bugfix/quote-regex-in-simplerelocator branch from 36a6b0a to 1feba03 Compare March 5, 2026 17:05
@kwin kwin merged commit f2dfe51 into master Mar 8, 2026
30 checks passed
@kwin kwin deleted the bugfix/quote-regex-in-simplerelocator branch March 8, 2026 18:44
@kwin kwin added the bug Something isn't working label Mar 8, 2026
@github-actions github-actions bot added this to the 3.6.3 milestone Mar 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SimpleRelocator doesn't quote regular expression patterns (pattern/pathPattern) correctly

2 participants