JAMES-3398 add Maven wrapper (with latest Maven version 3.6.3)#253
JAMES-3398 add Maven wrapper (with latest Maven version 3.6.3)#253aasaru wants to merge 4 commits intoapache:masterfrom
Conversation
chibenwa
left a comment
chibenwa
left a comment
There was a problem hiding this comment.
I think we should not commit binaries here. As a commiter, I can not ensure the authenticity nor the integrity of it. (I would not commit it to the james project as it is)
Your PR don't explain nor document how to use the wrapper (and why). A bit of ducmuentation in developer documentation could be helpful ;-)
Cheers.
…attributes that github adds by default)
|
@chibenwa , fair points both, I agree with you. I now removed the binary and added separate section to readme. I also improved the readme a bit. I investigated why IntelliJ IDEA complains about Readme.adoc and fixed some of the problems it pointed out (I couldn't fix titles that contain "+" sign so IntelliJ IDEA will still complain about those) |
chibenwa
left a comment
chibenwa
left a comment
There was a problem hiding this comment.
Sorry for radio silence.
I agree with the proposed changes, thanks for putting that together!
| import java.io.*; | ||
| import java.nio.channels.*; | ||
| import java.util.Properties; | ||
|
|
There was a problem hiding this comment.
I understand this code is copied but can we have a link to the place it was copied from as a comment?
This helps code patternity.
This helps checking divergences from the original version.
| # specific language governing permissions and limitations | ||
| # under the License. | ||
| # ---------------------------------------------------------------------------- | ||
|
|
There was a problem hiding this comment.
Idem, I would welcome a URL from where this was copied.
| @REM specific language governing permissions and limitations | ||
| @REM under the License. | ||
| @REM ---------------------------------------------------------------------------- | ||
|
|
|
A quick search yielded https://github.com/bdemers/maven-wrapper superseded by https://github.com/takari/maven-wrapper which itself mentions:
|
|
Note that maven 3.7.x and 3.8.x seem to have been abandonned in favor of maven 4.0.x |
|
Is there any plan to carry on this work? |
|
Note that 3.8.x was released after all and 4.0.x is still not available. |
3 participants
No description provided.