fix: Add i18n support for setting-drawer component#4006
Open
miantalha45 wants to merge 6 commits intoapache:masterfrom
Open
fix: Add i18n support for setting-drawer component#4006miantalha45 wants to merge 6 commits intoapache:masterfrom
miantalha45 wants to merge 6 commits intoapache:masterfrom
Conversation
- Created SettingDrawerI18nDirective to translate hardcoded Chinese text - Dynamically loads translations from i18n JSON files - Supports all languages: en-US, zh-CN, zh-TW, ja-JP, pt-BR - Added comprehensive test cases - Fixes issue where setting drawer showed Chinese text regardless of language setting
Member
|
pls check ci |
Author
|
@zqr10159 Please have a look into it. |
zqr10159
approved these changes
Feb 8, 2026
Author
|
@tomsun28 Any update on this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes
SettingDrawerI18nDirectiveto dynamically translate hardcoded Chinese text in the@delon/theme/setting-drawercomponentTechnical Details
@delon/theme/setting-drawercomponent has hardcoded Chinese text that doesn't support i18nTesting
Related Issue
Fixes #4004
