feat(compiler): add generated to_bytes/from_bytes methods to generated message/union
#3238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandalee99
approved these changes
Jan 28, 2026
2 tasks
chaokunyang
changed the title
to_bytes/from_bytes methods to generate message/unionto_bytes/from_bytes methods to generated message/union
chaokunyang
added a commit
that referenced
this pull request
Jan 29, 2026
#3236) ## Why? - Allow explicit control of ref tracking for nested list/map elements in xlang across languages. ## What does this PR do? - Add ref override markers for generic elements in codegen (Java `@Ref`, Python `Ref[...]`, Go `nested_ref` tag) and surface them in generated types. - Apply ref-override handling in Java/Go/Python collection/map serialization and generic type resolution so element ref tracking can be enabled/disabled independently. - Add cross-language collection element ref override tests (Java base + C++/Go/Python/Rust test mains) and a Java map serializer regression test. - Update `.gitignore` for new IDL-generated outputs. ## Related issues #3238 #3099 ## Does this PR introduce any user-facing change? - [x] Does this PR introduce any public API change? - [ ] Does this PR introduce any binary protocol compatibility change? ## Benchmark
chaokunyang
force-pushed
the
generate_to_from_bytes
branch
from
30f2008 to
ebe25bd
Compare
2 tasks
chaokunyang
added a commit
that referenced
this pull request
Jan 29, 2026
## Why? #3238 introduce a performance regression for deserialization ## What does this PR do? Fix performance regression for deserialization introduced in #3238 ## Related issues #2982 #3012 ## Does this PR introduce any user-facing change? - [ ] Does this PR introduce any public API change? - [ ] Does this PR introduce any binary protocol compatibility change? ## Benchmark
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
What does this PR do?
to_bytes/from_bytes(or language equivalents) for IDL messages/unions in C++/Go/Java/Python/Rust and update the generated-code docs/examples.SimpleForyPool,threadsafe.NewWithFactory,ThreadSafeForyfactory) and extend IDL integration tests to round-trip via the new helpers.Related issues
Closes #3237
#3099
Does this PR introduce any user-facing change?
Generated IDL code now exposes
to_bytes/from_byteshelpers and new registration helpers.Benchmark