[branch-52] Fix Internal error: Assertion failed: !self.finished: LimitedBatchCoalescer (#19785) #19836
+55
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…edBatchCoalescer (apache#19785) ## Which issue does this PR close? PR will close issue apache#19781. ## Rationale for this change Fixes the internal error ## What changes are included in this PR? The code change is inspired by the `CoalesceBatchesStream` implementation. ## Are these changes tested? Additional sqllogictest written in limit.slt which triggered the issue before the fix. ## Are there any user-facing changes? No --------- Co-authored-by: Bert Vermeiren <[email protected]>
github-actions
bot
added
documentation
alamb
changed the title
This was referenced Jan 15, 2026
xudong963
approved these changes
Jan 16, 2026
Contributor
Author
|
Thank you @xudong963 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Backport a regression found by @bert-beyondloops into the 52 release line
What changes are included in this PR?
Backport fix for #19781, #19785 to branch-52
Are these changes tested?
Yes
Are there any user-facing changes?
bug fix