datafusion/common: Add support for hashing ListView arrays #19814
+150
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jefffrey
approved these changes
Jan 14, 2026
Comment on lines
+1220
to
+1221
| assert_eq!(hashes[0], hashes[5]); // same content [0, 1, 2] | ||
| assert_eq!(hashes[1], hashes[4]); // both null | ||
| assert_eq!(hashes[2], hashes[3]); // same content [3, null, 5] | ||
| assert_eq!(hashes[1], hashes[6]); // null vs empty list |
Contributor
There was a problem hiding this comment.
Perhaps some negative tests to ensure hashes differ
Contributor
Author
There was a problem hiding this comment.
can you be more specific what you mean? are you just asking to test that eg. hash 0 and 2 are different?
martin-g
approved these changes
Jan 15, 2026
brancz
force-pushed
the
list-view-hash
branch
from
c53c593 to
cb84cab
Compare
Contributor
Author
|
We good to merge this? |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Implements the hashing part of #19782
Rationale for this change
To aggregate by ListView arrays, we need to be able to hash them.
What changes are included in this PR?
The hashing code and tests.
Are these changes tested?
Yes, unit tests.
Are there any user-facing changes?
No, only additive functionality.
@alamb @Jefffrey