GH-18652: [C++] Enhance arrow::internal::call_traits to support function pointers #48909
+98
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs (and maybe ...?)
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The
call_traitsutility only supported lambdas and functors, but not function pointers. This prevented simplifying code likefut.Then([](T x) { return Func(x); })tofut.Then(Func), as described in GH-18652.What changes are included in this PR?
arrow::internal::call_traitsincpp/src/arrow/util/functional.hAre these changes tested?
Yes, I ran all existing tests locally.
Are there any user-facing changes?
No.