GH-48853: [Release] Fix bytes to string comparison in download_rc_binaries.py #48896
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shashbha14
requested review from
assignUser,
jonkeane,
kou and
raulcd
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The download_rc_binaries.py script fails with a
TypeErrorwhen a download fails and it tries to check if the error is related to OpenSSL.What changes are included in this PR?
subprocess.Popen().communicate()returns bytes objects, but the code was comparingstderr(bytes) with a string"OpenSSL". Changed to use bytes literalb"OpenSSL"for proper comparison.Are these changes tested?
The fix is straightforward - using bytes literal instead of string literal for comparison with bytes object.
Are there any user-facing changes?
No.
Closes #48853