-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-48894: [Python][C++] Set minimum nodejs on conda env to 16 for Azurite to work and use base Azure::Core::RequestFailedException instead of final Azure::Storage::StorageException #48895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@github-actions crossbow submit test-conda-* |
|
|
|
Revision: 3fabe1d Submitted crossbow builds: ursacomputing/crossbow @ actions-cd25c6296c |
|
Moving this back to draft to investigate the segfault before fixing the nodejs version. |
…age::StorageException so we also catch Azure::Core::Http::TransportException
|
@github-actions crossbow submit -g cpp |
|
Revision: 3ccfdb7 Submitted crossbow builds: ursacomputing/crossbow @ actions-d7c2a57735 |
|
@pitrou is this what you expected? About factoring out the exception-catching code we can follow on a different issue if you want, I am unsure what that would require. |
Yes, it is. Did you check that it averted the crashes by turning them into proper errors?
Looking at the code, I'm not sure there's much to do about it, actually. |
|
@github-actions crossbow submit test-conda-python-3.13 |
|
Revision: b9b1ab6 Submitted crossbow builds: ursacomputing/crossbow @ actions-35c166620c
|
This reverts commit b9b1ab6.
|
@github-actions crossbow submit test-conda-python-3.13 |
|
Revision: a86bb98 Submitted crossbow builds: ursacomputing/crossbow @ actions-6ceafde0b6
|
Yes, I did locally but I've pushed a job without the nodejs bump so we can see it there. Pytest finishes running all tests, it doesn't crash anymore but tests fail as expected: opt/conda/envs/arrow/lib/python3.13/site-packages/pyarrow/tests/test_fs.py:329: in azurefs
fs.create_dir(container)
pyarrow/_fs.pyx:638: in pyarrow._fs.FileSystem.create_dir
???
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> ???
E OSError: Failed to create a container: pyarrow-filesystem: http://127.0.0.1:35357/devstoreaccount1/pyarrow-filesystem Azure Error: [] Fail to get a new connection for: http://127.0.0.1:35357. Could not connect to server |
Rationale for this change
nodejs 12 is currently being installed on conda. CI jobs are failing and or segfaulting due to azurite failing with old versions.
The job on PyArrow was segfaulting due to an Exception being thrown but not catch. In general we were using
Azure::Storage::StorageExceptionbutAzure::Core::Http::TransportExceptioncould also be thrown on some cases.Bot are final but inherit from
Azure::Core::RequestFailedException.What changes are included in this PR?
Azure::Storage::StorageExceptiontoAzure::Core::RequestFailedExceptionsoAzure::Core::Http::TransportExceptionis also catch.Are these changes tested?
Yes on CI.
Are there any user-facing changes?
No