-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-48885: [C++] Add missing curl dependency of Arrow::arrow_static CMake target
#48891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
raulcd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
6f73a88 to
b2de466
Compare
…atic` CMake target
|
Rebased. This is ready. CI failures are fixed. |
raulcd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@kou if I understand correctly the changes on the verify-xxx.sh scripts are so this will be surfaced on the Linux packaging jobs so we can prevent for these type of things happening again before releasing?
|
Correct. We can detect similar problems by new checks in |
Rationale for this change
We changed
macro(build_google_cloud_cpp_storage)tofunction(...)in GH-48333 . Sofind_curl()doesn't changeARROW_SYSTEM_DEPENDENCIESin parent scope. (function()creates a new scope.)What changes are included in this PR?
Move
find_curl()to the top-level from infunction(build_google_cloud_cpp_storage).Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.