-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-48921: [C++] Bump mimalloc to 3.2.7 #48826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
|
@github-actions crossbow submit -g cpp |
This comment was marked as outdated.
This comment was marked as outdated.
|
@github-actions crossbow submit wheelcp314* |
|
@ursabot please benchmark |
This comment was marked as outdated.
This comment was marked as outdated.
|
Two CI failures are relevant, I've opened upstream issues: |
|
@ursabot please benchmark |
|
@github-actions crossbow submit -g cpp |
|
@github-actions crossbow submit wheelcp314* |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
I've diagnosed the test freezes on Debian i386 and reported the issue. |
|
@github-actions crossbow submit -g r |
This comment was marked as outdated.
This comment was marked as outdated.
|
@github-actions crossbow submit -g cpp |
This comment was marked as outdated.
This comment was marked as outdated.
|
@github-actions crossbow submit -g packaging |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
@github-actions crossbow submit -g r -g cpp |
|
Revision: cfa3114 Submitted crossbow builds: ursacomputing/crossbow @ actions-0fbdfc8620 |
|
@ursabot please benchmark lang=C++ |
|
Benchmark runs are scheduled for commit 275a07b. Watch https://buildkite.com/apache-arrow and https://conbench.arrow-dev.org for updates. A comment will be posted here when the runs are complete. |
|
@rok trying to benchmark this one |
|
The C++ benchmarks seem to have run correctly. The R benchmarks can fail because of #48912 |
Ah interesting, I was about to bring this one up. |
zanmato1984
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
|
Thanks for your patience. Conbench analyzed the 3 benchmarking runs that have been run so far on PR commit 275a07b. There were 3 benchmark results indicating a performance regression:
The full Conbench report has more details. |
Rationale for this change
Bump mimalloc to the latest version.
On Linux platforms, this seems to make some Parquet reading benchmarks significantly faster.
Are these changes tested?
By existing CI builds.
Are there any user-facing changes?
Hopefully no regressions, but memory allocation behavior may change.