feat: allow output.preventDefault for command.before.execute#9417
Open
paoloricciuti wants to merge 4 commits intoanomalyco:devfrom
Open
feat: allow output.preventDefault for command.before.execute#9417paoloricciuti wants to merge 4 commits intoanomalyco:devfrom
output.preventDefault for command.before.execute#9417paoloricciuti wants to merge 4 commits intoanomalyco:devfrom
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Related PR FoundPR #9307: feat(hook): add noReply option to command.execute.before hook This PR is related to your changes because it also modifies the |
00637c0 to
71e0ba2
Compare
f1ae801 to
08fa7f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Just a small exploration but I wanted the ability to prevent the default navigation when invoking a command from a plugin so I asked claude to add it in and it seems like it did a good job. This adds an output property on
command.execute.beforewhere you can calloutput.preventDefaultto prevent the navigation...i've also implemented it for the TUI (maybe we should implement it for the webapp and the desktop too but wanted to see what you think about this).It's nice to give plugins the ability to create commands to do stuff rather than send a prompt (I could use this to allow the user to quickly enable/disable a feature in the svelte plugin for example).
How did you verify your code works?
Launched the version locally with a plugin that stops every command and show a toast.