Skip to content

refactor(desktop): tweak share button to prevent layout shift #9322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamdotdevin merged 1 commit into from
Jan 19, 2026
Merged

refactor(desktop): tweak share button to prevent layout shift #9322

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions packages/app/src/components/session/session-header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,11 @@ export function SessionHeader() {
}
trigger={
<Tooltip class="shrink-0" value="Share session">
<Button variant="secondary" classList={{ "rounded-r-none": shareUrl() !== undefined }}>
<Button
variant="secondary"
classList={{ "rounded-r-none": shareUrl() !== undefined }}
style={{ scale: 1 }}
>
Share
</Button>
</Tooltip>
Expand Down Expand Up @@ -293,12 +297,12 @@ export function SessionHeader() {
</Show>
</div>
</Popover>
<Show when={shareUrl()}>
<Show when={shareUrl()} fallback={<div class="size-6" aria-hidden="true" />}>
<Tooltip value={state.copied ? "Copied" : "Copy link"} placement="top" gutter={8}>
<IconButton
icon={state.copied ? "check" : "copy"}
variant="secondary"
class="rounded-l-none border-l border-border-weak-base"
class="rounded-l-none"
onClick={copyLink}
disabled={state.unshare}
/>
Expand Down