fix(Sqlite): Removed deprecated exec method and moved Session import to migrateFromGlobal function
#9268
+2,377
−384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r query performance
…in Project namespace to prevent `Cannot access 'Instance' before initialization.` error
…ath "migration" instead of "drizzle"
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removed remaining deprecated
sqlite.exec->sqlite.runMoved
Sessionsimport to be dynamic when used by themigrateFromGlobalfixes theReferenceError: Cannot access 'Instance' before initialization.that comes when trying to start the TUI.Update
generate-migrations.tsscript to make the import statement to get migrations from the right path "migrations" not "drizzle".How did you verify your code works?
I was able to properly run the TUI on the branch and the migration ran and local DB created.
The autogenerated migrations file pointed to the right migration sql and the DB was properly migrated.