Skip to content

Scrollable dialog #10586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
phall1 wants to merge 2 commits into from
Closed

Scrollable dialog #10586

phall1 wants to merge 2 commits into from

Conversation

@phall1
Copy link

@phall1 phall1 commented Jan 25, 2026

What does this PR do?

How did you verify your code works?

Patrick Hall added 2 commits January 25, 2026 16:38
feat(tui): add scrollable dialog
7303c71 
- Wrap DialogStatus content in scrollbox with max-height
- Fix dialog centering by adjusting paddingTop to 3 rows
- Prevents overflow when showing many items (MCP servers, LSPs, etc.)
some adjustments to scrolling
050a799
@github-actions
Copy link
Contributor

github-actions bot commented Jan 25, 2026

Hey! Your PR title Scrollable dialog doesn't follow conventional commit format.

Please update it to start with one of:

  • feat: or feat(scope): new feature
  • fix: or fix(scope): bug fix
  • docs: or docs(scope): documentation changes
  • chore: or chore(scope): maintenance tasks
  • refactor: or refactor(scope): code refactoring
  • test: or test(scope): adding or updating tests

Where scope is the package name (e.g., app, desktop, opencode).

See CONTRIBUTING.md for details.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 25, 2026

The following comment was made by an LLM, it may be inaccurate:

Based on my search results, I found a highly related PR:

PR #9315 - feat(tui): makes status dialog scrollable
#9315

This appears to be closely related as it addresses making a dialog scrollable (status dialog specifically), which is likely the same feature or component being addressed in PR #10586.

Additionally, PR #6677 - fix(tui): add scroll to the status dialog
#6677

This is another PR that adds scroll functionality to a dialog.

These PRs should be reviewed to ensure there's no overlapping work on dialog scrollability features.

@phall1 phall1 closed this Jan 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

needs:title

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@phall1