Remove obsolete, duplicate, and useless docs. #1156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License text, setup instructions, and support info do not need to be duplicated into every README, since they're already in the top-level README. They were originally in each sample because the samples used to each be separate Android Studio projects with different requirements that could be checkout out independently in Android Studio. This is no longer the case. Most of the docs also included text along the lines of "This sample uses the new Android Studio with CMake support", which hasn't been new since 2015, so doesn't really need to be said. The prerequisites were mostly not true. Android Studio is not required for any of this. Cloning the repo and running `./gradlew build` is sufficient to build all the samples. They also were not being kept up-to-date at all, since they mostly said "Android Studio 2.2 or newer", which was definitely not true. I'm not what the oldest version of Android Studio that will work here is, but I don't actually test anything but the latest so claiming anything otherwise is just misleading. I haven't pruned or edited any of the real content of the docs. I'm sure there are plenty of edits to be made there and a lot of expansion to do, but those changes will be less mechanical and will happen separately.
enh-google
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
License text, setup instructions, and support info do not need to be
duplicated into every README, since they're already in the top-level
README. They were originally in each sample because the samples used to
each be separate Android Studio projects with different requirements
that could be checkout out independently in Android Studio. This is no
longer the case.
Most of the docs also included text along the lines of "This sample uses
the new Android Studio with CMake support", which hasn't been new since
2015, so doesn't really need to be said.
The prerequisites were mostly not true. Android Studio is not required
for any of this. Cloning the repo and running
./gradlew buildissufficient to build all the samples. They also were not being kept
up-to-date at all, since they mostly said "Android Studio 2.2 or newer",
which was definitely not true. I'm not what the oldest version of
Android Studio that will work here is, but I don't actually test
anything but the latest so claiming anything otherwise is just
misleading.
I haven't pruned or edited any of the real content of the docs. I'm sure
there are plenty of edits to be made there and a lot of expansion to do,
but those changes will be less mechanical and will happen separately.