Add an AST visitor module and refactor the code generation to use it.#70
Open
jvprat wants to merge 3 commits intoandremm:masterfrom
Open
Add an AST visitor module and refactor the code generation to use it.#70jvprat wants to merge 3 commits intoandremm:masterfrom
jvprat wants to merge 3 commits intoandremm:masterfrom
Conversation
jvprat
force-pushed
the
visitor
branch
4 times, most recently
from
26f5395 to
01dfe46
Compare
jvprat
force-pushed
the
visitor
branch
3 times, most recently
from
ef86fc3 to
a740d25
Compare
Collaborator
|
It seems like the visitor module's default visitor would make it simpler to implement visitors that only need to act on specific AST nodes, correct? Could you do a new pull request with just the visitor module, without converting the existing code generator and type checker? Thanks! |
Owner
|
@mascarenhas can we close this after merging PR #115 ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows code reuse when navigating the AST, and it allows new modules that handle a few node types to be much smaller and simpler (I'm working on a new module).
In addition, the code generation and the checker are updated to use it, and some funcionts are split into smaller functions that handle concrete node types.