External packages #98
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandraBara
requested review from
jaspals3123 and
landrews-amd
as code owners
- Changed from paramiko~=3.5.1 to paramiko>=3.2.0,<4.0.0 - Allows broader compatibility with downstream dependencies - Uses only basic paramiko features stable since 3.2.0
alexandraBara
force-pushed
the
alex_ext_pkg
branch
from
f70dc6c to
55920b2
Compare
… (or venv\Scripts on Windows) to sys.path[0] This breaks importlib.metadata.distributions() from discovering editable installs which results in xternal plugins from packages like amd-error-scraper weren't being found
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhanced external package discovery by looking for ext_nodescraper_plugins namespace in installed packages as well.