Skip to content

fix: allow null value in ComboBox validate for single selection #9742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
snowystinger merged 1 commit into from
Mar 16, 2026
+1 −1
Merged

fix: allow null value in ComboBox validate for single selection #9742

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/@react-types/combobox/src/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export type MenuTriggerAction = 'focus' | 'input' | 'manual';
export type SelectionMode = 'single' | 'multiple';
export type ValueType<M extends SelectionMode> = M extends 'single' ? Key | null : readonly Key[];
export type ChangeValueType<M extends SelectionMode> = M extends 'single' ? Key | null : Key[];
type ValidationType<M extends SelectionMode> = M extends 'single' ? Key : Key[];
type ValidationType<M extends SelectionMode> = M extends 'single' ? Key | null : Key[];
Copy link
Member

@snowystinger snowystinger Mar 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems incorrect, null should not be allowed. it's considered valid unless marked required in which case required validation will take care of it

if the assertion that allowsCustomValue can be called with null, then that seems like a bug

Copy link
Contributor Author

@lixiaoyan lixiaoyan Mar 16, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, we pass { inputValue, value } as the argument to the validate function, and we only skip validation when this argument is null. This means that in single-select scenarios, arg.value can indeed be null.

For multi-select scenarios, however, we intentionally set the entire argument to null within useComboBoxState to bypass validation. This admittedly introduces an inconsistency. However, given that arg.inputValue is primarily used for filtering in multi-select, skipping validation in this context is reasonable to some extent.

On the other hand, for single-select—especially when allowsCustomValue is enabled—we might have validations that rely solely on arg.inputValue (ignoring arg.value entirely). Therefore, I believe it makes sense to let the validation execute normally even when arg.value is null.

https://stackblitz.com/edit/49ftjwz8?file=src%2FExample.tsx

image

Copy link
Contributor Author

@lixiaoyan lixiaoyan Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have split the changes into two separate PRs (the other one is #9795), so they can now be reviewed independently.

Copy link
Member

@devongovett devongovett Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense. Thanks for explaining.


export interface ComboBoxValidationValue<M extends SelectionMode = 'single'> {
/**
Expand Down
Loading