-
Notifications
You must be signed in to change notification settings - Fork 24
Move new SSD1680 driver variant to dedicated module and update examples #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- no logic changes from the vanilla SSD1680 driver -- will be applied in the next commit for diff clarity - update copyright/author sections - remove unnecessary pylint directives
|
Thanks for doing this, I was finally able to get me 2.13" bonnet to start working 🙏 |
|
I resolved the conflicts with the |
|
@makermelissa, this should be up-to-date and good to go again. Let me know if there's anything blocking the merge, I'll be happy to adjust it. |
|
Hey @BlitzCityDIY, is there anything I can do to help get this merged? Without this PR being merged, the
I created both of these PRs in the first place because I was trying to follow the learning system guide and it didn't work. It sounds like the same is still happening to people (e.g. #86 (comment)) at least until they find this PR and realize the learning system is referring to this unmerged branch. It would be nice to get things straightened out. If there's something about this PR that strictly prohibits being merged, I'm happy to help get the learning system content back in line with the existing release of this package. |
|
hihi- sorry fell off my radar. i will review monday (tomorrow) |
BlitzCityDIY
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
Updating https://github.com/adafruit/Adafruit_CircuitPython_EPD to 2.18 from 2.17.1: > Merge pull request adafruit/Adafruit_CircuitPython_EPD#86 from joxl/jm/ssd1680b-driver-module > Merge pull request adafruit/Adafruit_CircuitPython_EPD#98 from adafruit/il0373_update
This PR refactors @mikeysklar's recent driver addition into a dedicated module, updates the examples and adds a new example which I used while testing the new driver.
I moved the driver into its own module and named it "B" (instead of "Z") to maintain consistency with all the other drivers. While trying to locate datasheet details for the new device, I was initially confused by the "SSD1680Z" name because (as I eventually came to realize) the "Z" suffix refers to one of the die packaging options for the SSD1680, rather than a unique die. I decided to rename the Adafruit driver class to "SSD1680B", which (I think) follows the same convention used for a second variant of the
SSD1675driver. To maintain backwards compatibility (prevent breaking changes), theAdafruit_SSD1680Zname can still be imported from theadafruit_epd.ssd1680module.In addition to the class name change, there were a few other minor adjustments made during the refactor, including:
pylint: disabledirectivesNOPcommand (wrong hex value, also for completeness as the NOP isn't currently used in this driver)I also updated the example scripts that follow the "import lots of drivers with usage comments for each" convention, and also added my own (new) example script (with accompanying "grid" bitmap image) which I found useful during driver testing -- the grid image makes it easier to detect if any rows of pixels are missing or offset.
I'm also preparing another PR for the
adafruit/Adafruit_Learning_System_Guidesproject with updates for the Event Calendar and Weather Station learning guides.Note to reviewers: (cc @ladyada) I applied license headers to all new files as I observed in other places. I'm pretty confident I got it right, but I wasn't able to find a specific document in the repo that says "do license headers like XYZ". Maybe I didn't look hard enough, but if there is such a document, I'd be happy to read it to make sure I've done it correctly.
Recommended review: commit by commit.
Closes #85