Skip to content

Conversation

@anonrig
Copy link
Member

@anonrig anonrig commented Dec 10, 2025

Upgrade to clang-format-21 and clang-tidy-21

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 10, 2025

CodSpeed Performance Report

Merging #1036 will degrade performances by 99.99%

Comparing yagiz/clang-format-21 (72cd08f) with main (236e519)

Summary

❌ 1 regression
✅ 18 untouched
⏩ 3 skipped1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
BasicBench_whatwg 31.7 µs 213,731.8 µs -99.99%

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@anonrig
Copy link
Member Author

anonrig commented Dec 10, 2025

@CarlosEduR would you mind taking a look at BasicBench_whatwg benchmark? it's probably having the same exact issue...

@CarlosEduR
Copy link
Member

@CarlosEduR would you mind taking a look at BasicBench_whatwg benchmark? it's probably having the same exact issue...

sure, I will take a look

@CarlosEduR
Copy link
Member

The lint and format pipeline failed, looks like clang++-21 isn't installed:

CMake Error at /usr/local/share/cmake-3.31/Modules/CMakeDetermineCXXCompiler.cmake:48 (message):
  Could not find compiler set in environment variable CXX:

  clang++-21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants