Skip to content

Add alpine in RANGE_CLASS_BY_SCHEME#185

Merged
keshav-space merged 2 commits intoaboutcode-org:mainfrom
Samk1710:alpine
Feb 25, 2026
Merged

Add alpine in RANGE_CLASS_BY_SCHEME#185
keshav-space merged 2 commits intoaboutcode-org:mainfrom
Samk1710:alpine

Conversation

@Samk1710
Copy link
Contributor

Signed-off-by: Samk <sampurnapyne1710@gmail.com>
Copy link
Member

@keshav-space keshav-space left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Samk1710, please add few tests for AlpineLinuxVersionRange.

Signed-off-by: Samk <sampurnapyne1710@gmail.com>
@Samk1710
Copy link
Contributor Author

@keshav-space Done adding the tests.

Followed existing patterns of test_version_range_intdot and test_OpensslVersionRange_from_versions

Test logs:

collected 3 items                                                                                 

tests/test_version_range.py::test_AlpineLinuxVersionRange_from_versions PASSED              [ 33%]
tests/test_version_range.py::test_apk_in_RANGE_CLASS_BY_SCHEMES PASSED                      [ 66%]
tests/test_version_range.py::test_alpine_version_range_containment PASSED                   [100%]

======================================== 3 passed in 0.38s ========================================

Kindly take a look when time.

Copy link
Member

@keshav-space keshav-space left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Samk1710, LGTM!

@keshav-space keshav-space merged commit f94ff10 into aboutcode-org:main Feb 25, 2026
2 checks passed
@Samk1710
Copy link
Contributor Author

Thanks for the review @keshav-space.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants