Hide suggestion upvoters in admin to prevent accidental overwrite (T3…#1511
Merged
suecarmol merged 3 commits intoWikipediaLibrary:masterfrom Feb 14, 2026
Merged
Conversation
Contributor
Author
|
@Samwalton9 is it solve the issue? |
Member
|
Could you share a screenshot of your changes locally, showing this having the intended effect, please? |
Contributor
Author
|
@Samwalton9 can you check now? |
Member
|
That's great, thank you :) |
Contributor
Author
|
Thanks for the confirmation! |
Contributor
|
Thank you for your PR! A formatting test is failing. Can you run |
…into hide-upvoters-admin
Contributor
Author
|
@suecarmol check once |
suecarmol
approved these changes
Feb 14, 2026
Contributor
suecarmol
left a comment
There was a problem hiding this comment.
Thank you for making these changes!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…75172)
Description
This PR hides the
upvoted_usersfield from the Django admin interfacefor Suggestions.
The admin edit form previously exposed a multi-select widget for
upvoters, which could accidentally overwrite existing upvotes when
admins edited unrelated fields such as Phabricator task IDs.
Describe your changes in detail following the commit message guidelines
Rationale
The upvoter list is not intended to be edited manually by administrators.
Exposing it in the admin UI makes it easy to accidentally clear or reduce
upvotes when saving the form.
Hiding this field prevents unintended data loss and improves admin safety.
Phabricator Ticket
https://phabricator.wikimedia.org/T375172
How Has This Been Tested?
/adminwithout modifying upvotes.remain unchanged after saving.
Screenshots of your changes (if appropriate):
Types of changes
What types of changes does your code introduce? Add an
xin all the boxes that apply: