fix: use semver when parsing vcpkg json #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donny-dont
force-pushed
the
fix-vcpkg-version
branch
from
dbd59d3 to
6147604
Compare
If there was no patch version in the `vcpkg.json` the `vcpkg` command would erroneously report an update was available. Parse into `semver.Version` and then use that for comparisons.
donny-dont
force-pushed
the
fix-vcpkg-version
branch
from
6147604 to
e08d231
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there was no patch version in the
vcpkg.jsonthevcpkgcommand would erroneously report an update was available. Parse intosemver.Versionand then use that for comparisons.