fix: correct fee calculation for exactOut swaps in afterSwap example#1109
Open
Kropiunig wants to merge 1 commit intoUniswap:mainfrom
Open
fix: correct fee calculation for exactOut swaps in afterSwap example#1109Kropiunig wants to merge 1 commit intoUniswap:mainfrom
Kropiunig wants to merge 1 commit intoUniswap:mainfrom
Conversation
The afterSwap hook fee example incorrectly calculated the fee amount using outputAmount for both exactIn and exactOut swaps. However, as noted in the documentation tip, the returned int128 is for the unspecified currency: - exactIn: unspecified = output token - exactOut: unspecified = input token The previous code always used outputAmount to compute feeAmount, which is incorrect for exactOut swaps where the fee should be calculated from the input amount. This fix: - Determines the unspecified token based on swap type - Uses the correct amount (output for exactIn, input for exactOut) - Simplifies feeCurrency assignment since it always matches unspecifiedIsToken0 Fixes Uniswap#1101
|
@Kropiunig is attempting to deploy a commit to the Uniswap Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug in the
afterSwaphook fee example where the fee amount was incorrectly calculated for exact output swaps.The issue: The documentation correctly states that the returned
int128is for the unspecified currency (output for exactIn, input for exactOut), but the code example always calculated the fee fromoutputAmount, which is wrong for exactOut swaps.The fix:
Changes
Fixes #1101