-
Notifications
You must be signed in to change notification settings - Fork 230
Fix missing fallback argument for InitFromParams(::ModeResult)
#2736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Turing.jl documentation for PR #2736 is available at: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2736 +/- ##
=======================================
Coverage 55.34% 55.34%
=======================================
Files 20 20
Lines 1254 1254
=======================================
Hits 694 694
Misses 560 560 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sunxd3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good in current state, will take another look once DPPL PR goes through
|
@sunxd3 dppl pr went through :) |
|
thanks, taking a look shortly |
| DistributionsAD = "0.6" | ||
| DocStringExtensions = "0.8, 0.9" | ||
| DynamicHMC = "3.4" | ||
| DynamicPPL = "0.39.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bump this too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking it's not really necessary to bump, since technically using the old version is still fine, you just don't get this functionality
sunxd3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #2607.
Note that this requires TuringLang/DynamicPPL.jl#1171 to go through first. Hence I can't add a test. But once the DPPL one is done, I will add the following test, which works locally:Test added