P2: Lila 5632/update redeemauto function to work like autoredeem2 in offsethelper#23
Draft
GigaHierz wants to merge 2 commits intoToucanProtocol:mainfrom
Conversation
toucan-robot
changed the title
GigaHierz
force-pushed
the
LILA-5632/update-redeemauto-function-to-work-like-autoredeem2-in-offsethelper
branch
from
cbf5662 to
e93d9e4
Compare
|
@GigaHierz the smart contracts check is failing. Is this to be ignored? |
0xmichalis
requested changes
Oct 16, 2023
Member
0xmichalis
left a comment
0xmichalis
left a comment
There was a problem hiding this comment.
The tests are failing because redeemAuto in production for the pools does not return arguments as redeemAuto2 does. We cannot merge this change just yet and it's a low priority so I would postpone for later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR is blocked because of tests failing.
This is because
redeemAutodoes not return args yet in production so this change cannot be done before a pool upgrade.