feat: Add include_sql to Search Pipeline Run API#135
Open
yuechao-qin wants to merge 1 commit intoycq/search-pipeline-run-pagination-cursorfrom
Open
feat: Add include_sql to Search Pipeline Run API#135yuechao-qin wants to merge 1 commit intoycq/search-pipeline-run-pagination-cursorfrom
include_sql to Search Pipeline Run API#135yuechao-qin wants to merge 1 commit intoycq/search-pipeline-run-pagination-cursorfrom
Conversation
This was referenced Feb 28, 2026
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Feb 28, 2026
6cede38 to
91f679a
Compare
8b74a37 to
9b0355f
Compare
Contributor
|
I'm not sure we should support this in public API. It's pretty simple to locally compile arbitrary filter_query or page_token to arbitrary SQL dialect. Let's discuss the primary use case and decide how to accomplish that goal without adding this debug information to the public API surface. |
Collaborator
Author
|
9b0355f to
4c82c95
Compare
91f679a to
4845319
Compare
yuechao-qin
commented
Mar 4, 2026
| class ListPipelineJobsResponse: | ||
| pipeline_runs: list[PipelineRunResponse] | ||
| next_page_token: str | None = None | ||
| sql: str | None = None |
Collaborator
Author
There was a problem hiding this comment.
Brainstorming ideas:
- add "_" in front of paramter "_include_sql"
- hide include_sql from openapi
- add this to oasis-backend not tangle (https://oasis.shopify.io/api/stats/quick?format=html)
4c82c95 to
9847bfa
Compare
4845319 to
ba1db33
Compare
ba1db33 to
44d878f
Compare
9847bfa to
395dc95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

TL;DR
Added optional SQL query debugging to the pipeline runs list API endpoint.
What changed?
Functional
include_sqlparameter to APIsqlfield toListPipelineJobsResponseto optionally return the generated SQL queryHow to test?
include_sql=Trueto verify the SQL query is returned in the responseinclude_sql=Falseor is omitted, thesqlfield remainsNoneWhy make this change?