Skip to content

feat: display job details if available in task context panel#1874

Merged
maxy-shpfy merged 1 commit intomasterfrom
02-27-feat_display_job_details_if_available_in_task_context_panel
Mar 2, 2026
Merged

feat: display job details if available in task context panel#1874
maxy-shpfy merged 1 commit intomasterfrom
02-27-feat_display_job_details_if_available_in_task_context_panel

Conversation

@maxy-shpfy
Copy link
Collaborator

@maxy-shpfy maxy-shpfy commented Feb 27, 2026

Description

Added Kubernetes job status information to the ExecutionDetails component. The enhancement displays job execution metrics including completion duration, parallelism settings, success/failure counts with index details, and completed indexes. This provides better visibility into Kubernetes job execution status directly in the task details view.

Related Issue and Pull requests

Type of Change

  • Bug fix
  • New feature
  • Improvement
  • Cleanup/Refactor
  • Breaking change
  • Documentation update

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

image.png

Test Instructions

  1. Navigate to a task that uses Kubernetes job execution
  2. Open the ExecutionDetails view
  3. Verify that job status information is displayed including:
    • Job completion duration (if job has completed)
    • Job parallelism setting
    • Success/failure counts with index information
    • Completed indexes information
  4. Confirm that failed jobs display with critical styling
  5. Test with jobs that have different status combinations (succeeded, failed, in-progress)

Additional Comments

The implementation includes helper functions for safely extracting nested properties from the debug_info object and handles cases where job status information may be incomplete or unavailable.

@github-actions
Copy link

github-actions bot commented Feb 27, 2026

🎩 To tophat this PR:

You can add the following URL parameter to your browser to tophat this PR:

`?tophat_location=02-27-feat_display_job_details_if_available_in_task_context_panel/0c935d5`

Copy link
Collaborator Author

maxy-shpfy commented Feb 27, 2026

@maxy-shpfy maxy-shpfy marked this pull request as ready for review February 27, 2026 20:05
@maxy-shpfy maxy-shpfy requested a review from a team as a code owner February 27, 2026 20:05

if (completedIndexes) {
items.push({
label: "Job completed on indexes",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Can we improve the language so it is more human friendly? Indexes is a pretty general term rather than descriptive,

As a reader, I would be thinking "What indexes?"

Maybe just added the word "Node" would help. "Job completed on node indexes"

Copy link

Left a small comment on copy but looks good!

Copy link
Collaborator Author

maxy-shpfy commented Mar 2, 2026

Merge activity

  • Mar 2, 10:23 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Mar 2, 10:27 PM UTC: Graphite rebased this pull request as part of a merge.
  • Mar 2, 10:29 PM UTC: @maxy-shpfy merged this pull request with Graphite.

@maxy-shpfy maxy-shpfy changed the base branch from 02-27-feat_display_job_name_for_multi-node_executions to graphite-base/1874 March 2, 2026 22:24
@maxy-shpfy maxy-shpfy changed the base branch from graphite-base/1874 to master March 2, 2026 22:26
@maxy-shpfy maxy-shpfy force-pushed the 02-27-feat_display_job_details_if_available_in_task_context_panel branch from a9daf11 to 0c935d5 Compare March 2, 2026 22:27
@maxy-shpfy maxy-shpfy merged commit 610ddae into master Mar 2, 2026
15 checks passed
@maxy-shpfy maxy-shpfy deleted the 02-27-feat_display_job_details_if_available_in_task_context_panel branch March 2, 2026 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants