fix: support dynamic arguments in usecomponentspectoedges hook#1868
Open
maxy-shpfy wants to merge 1 commit intomasterfrom
Open
fix: support dynamic arguments in usecomponentspectoedges hook#1868maxy-shpfy wants to merge 1 commit intomasterfrom
maxy-shpfy wants to merge 1 commit intomasterfrom
Conversation
🎩 To tophat this PR:You can add the following URL parameter to your browser to tophat this PR: |
maxy-shpfy
force-pushed
the
02-26-fix_support_dynamic_arguments_in_usecomponentspectoedges_hook
branch
from
1e5679a to
eef8df4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added handling for dynamic data arguments in the edge creation logic. Dynamic data arguments are now treated the same as secret arguments and will not generate edges in the component specification to edges conversion process.
Related Issue and Pull requests
Type of Change
Checklist
Screenshots (if applicable)
Screen Recording 2026-02-26 at 5.56.49 PM.mov (uploaded via Graphite)
Test Instructions
Additional Comments
This change ensures that dynamic data arguments follow the same edge creation pattern as secret arguments, preventing unnecessary edge generation in the graph structure.