fix: ReactFlow Warnings due to Edge Rendering & Hydration Conflicts#1865
Open
fix: ReactFlow Warnings due to Edge Rendering & Hydration Conflicts#1865
Conversation
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
camielvs
force-pushed
the
02-25-fix_reactflow_warnings_due_edge_rendering_hydration_conflicts
branch
6 times, most recently
from
614baf8 to
223ec16
Compare
camielvs
changed the title
camielvs
force-pushed
the
02-25-fix_reactflow_warnings_due_edge_rendering_hydration_conflicts
branch
from
223ec16 to
cb946e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Due to recent changes to component hydration - namely, moving hydration into the task provider - components are now suspended before being rendered on canvas. This results in ReactFlow giving warnings in console about missing handles and nodes. Once the hydration process completes the warnings go away and the graph renders as expected.
This PR aims to solve this issue by pre-hydrating components and saving them to cache when the component spec is first loaded, i.e. before FlowCanvas even begins rendering.
Related Issue and Pull requests
Type of Change
Checklist
Screenshots (if applicable)
Test Instructions
Additional Comments