chore: Add onEnter and onEscape to Input Component#1850
Open
camielvs wants to merge 1 commit into02-23-feat_submit_pipeline_tags_on_runsfrom
Open
chore: Add onEnter and onEscape to Input Component#1850camielvs wants to merge 1 commit into02-23-feat_submit_pipeline_tags_on_runsfrom
camielvs wants to merge 1 commit into02-23-feat_submit_pipeline_tags_on_runsfrom
Conversation
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
3 tasks
camielvs
force-pushed
the
02-23-chore_add_onenter_and_onescape_to_input_component
branch
from
e07ea07 to
39e086e
Compare
maxy-shpfy
reviewed
Feb 26, 2026
Comment on lines
+32
to
+33
| onEnter?: () => void; | ||
| onEscape?: () => void; |
Collaborator
There was a problem hiding this comment.
I do like the idea - simplifies a lot. I noticed that in most cases onEnter means "onSave" and "onEscape" means "onCancel". So maybe we should name them same way?
E.g. in InlineTextEditor same named as "onSave" and "onCancel" - we may introduce naming inconsistencies or establish a good convention.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add native
onEnterandonEscapehandlers toInputcomponent to streamline use of these common actions.Related Issue and Pull requests
Type of Change
Checklist
Screenshots (if applicable)
Test Instructions
Additional Comments