Skip to content

fix?? #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tannerlinsley merged 2 commits into from
Dec 20, 2025
Merged

fix?? #597

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91afa4c
fix: remove unnecessary dependency from useEffect in FeedFilters
LadyBluenotes Dec 20, 2025
6c31c7a
Merge branch 'main' into fix
LadyBluenotes Dec 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/FeedFilters.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@
// Update filters when debounced search changes
React.useEffect(() => {
onFiltersChange({ search: debouncedSearch || undefined })
}, [debouncedSearch, onFiltersChange])
}, [debouncedSearch])

Check warning on line 139 in src/components/FeedFilters.tsx

View workflow job for this annotation

GitHub Actions / PR 

React Hook React.useEffect has a missing dependency: 'onFiltersChange'. Either include it or remove the dependency array. If 'onFiltersChange' changes too often, find the parent component that defines it and wrap that definition in useCallback

// Sync local state with prop when search prop changes externally
React.useEffect(() => {
Expand Down
Loading