Propose: Allow custom scripts to be loaded from a JSON file.#99
Open
SaintWish wants to merge 3 commits intoTES3MP:0.8.0from
Open
Propose: Allow custom scripts to be loaded from a JSON file.#99SaintWish wants to merge 3 commits intoTES3MP:0.8.0from
SaintWish wants to merge 3 commits intoTES3MP:0.8.0from
Conversation
Member
|
Can you rename "scripts.json" into "customScripts.json" first? |
Contributor
|
in this case, what do we do with the OnServerInit and OnServerPostInit events in our personnalized files ? I use it regularly for creating things at startup |
|
Perhaps the loading should be done in OnServerInit instead? That way you still get the event emission? Really there should only be one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it would more neat to load custom scripts from a JSON file instead of modifying
customScripts.lua, similar to how via data files are loaded. It's also configurable from theconfigtable and obeys the order from the JSON file.Currently, the custom scripts are loaded
OnServerPostInit, I couldn't think of a better place of where scripts should be loaded. This would also resolve this issue #80I'm open to any suggestions.
Here's what the JSON file would look like.
[ {"script1": "custom/script1"}, //This script would be loaded first since it's first in the list. {"script2": "custom/script2"}, {"someScript": "custom/someScript/main"} ]