refactor: fix external link component #3935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
You can access the deployment of this PR at https://renku-ci-ui-3935.dev.renku.ch |
lorenzo-cavazzi
requested changes
Jan 6, 2026
Member
lorenzo-cavazzi
left a comment
lorenzo-cavazzi
left a comment
There was a problem hiding this comment.
Nice change!
Just a couple of nitpicky comments on the examples. Otherwise, ready to merge.
Co-authored-by: Lorenzo Cavazzi <[email protected]>
Contributor
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3687.
Add a new component
<ExternalLink>and moves the existing ones toLegacyExternalLinks.tsx.The new
<ExternalLink>component renders a simple link with the box up-right arrow icon./deploy extra-values=enableInternalGitlab=false