Fixed some stuff, made a few small changes, removed Java 16 code#2
Open
Asbestosstar wants to merge 6 commits intoSpruceLoader:mainfrom
Open
Fixed some stuff, made a few small changes, removed Java 16 code#2Asbestosstar wants to merge 6 commits intoSpruceLoader:mainfrom
Asbestosstar wants to merge 6 commits intoSpruceLoader:mainfrom
Conversation
Before it was not working because of multiple issues with the Classloader which I have fixed. Its not perfect, but it at least boots into the game which it could not before. I have also removed some of the Java 16 and newer specific code to work on Java 8 and 11. This updated version was able to Launch on TL with my RHEL9 system. It even said modded (which for some reason it did not on Vanilla FC despite having similar JSON). Anyhow I hope this works for you.
TheKodeToad
approved these changes
Apr 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before it was not working because of multiple issues with the Classloader which I have fixed. Its not perfect, but it at least boots into the game which it could not before. I have also removed some of the Java 16 and newer specific code to work on Java 8 and 11. This updated version was able to Launch on TL with my RHEL9 system. It even said modded (which for some reason it did not on Vanilla FC despite having similar JSON). Anyhow I hope this works for you.