Open
Conversation
mathiasgredal
force-pushed
the
bgfx-backend
branch
5 times, most recently
from
ff6322a to
b2a64a7
Compare
mathiasgredal
force-pushed
the
bgfx-backend
branch
3 times, most recently
from
40910b9 to
c18bf49
Compare
Author
|
@SpaiR I have some time on my hand currently. Is there any interest in getting this feature merged if I fix the conflicts. Are there any changes to the implementation approach or feedback that you have? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I have made a basic imgui backend for bgfx. It is not as fancy as the OpenGL one, since it can't handle multi viewport and doesn't render other textures than the font texture.
Type of change
Added a new bgfx backend in addition to the OpenGL one.
I have flipped the inheritance hierarchy such that instead of the application inheriting from window it is instead the window that inherits from the application. This makes it easy for the user to choose which backend they would like to use. Unfortunately it is a breaking change, I don't know if there is a better way to do this.