allow users to join global rooms by suffixing URL with /custom-room-id#620
Draft
kiprasmel wants to merge 1 commit intoSnapDrop:masterfrom
Draft
allow users to join global rooms by suffixing URL with /custom-room-id#620kiprasmel wants to merge 1 commit intoSnapDrop:masterfrom
kiprasmel wants to merge 1 commit intoSnapDrop:masterfrom
Conversation
kiprasmel
changed the title
simple solution: snapdrop.net/ -> room by IP snapdrop.net/foo -> room foo, no matter what IP invalidates a previously faulty PR: SnapDrop#288 and provides an alternative: specify the `snapdrop_mount` if you app is deployed on a different URL than `/`. it's not a "hack" to substitute the path via a command, like the home assistant guys used to do [1] -- it's normal, because you're doing a non-standard deployment. i just simplified how it'd need to be done now, while for everyone else, the easy room switching becomes available. [1] deftdawg/homeassistant-addons@29f99c1
kiprasmel
force-pushed
the
simple-custom-rooms-by-url
branch
from
c384679 to
8f2685d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
simple solution:
snapdrop.net/ -> room by IP
snapdrop.net/foo -> room foo, no matter what IP
invalidates a previously faulty PR: #288
and provides an alternative: specify the
snapdrop_mountif you app is deployed on a different URL than/.it's not a "hack" to substitute the path via a command, like the home assistant guys used to do [1] -- it's normal, because you're doing a non-standard deployment. i just simplified how it'd need to be done now, while for everyone else, the easy room switching becomes available.
[1] deftdawg/homeassistant-addons@29f99c1